Thanks for the contribution! Unfortunately we can't verify the commit author(s): Arnulfo Solis <a***@A***.com>. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, sign the Salesforce.com Contributor License Agreement and this Pull Request will be revalidated.

Thanks for the contribution! Before we can merge this, we need @arnulfojr to sign the Salesforce.com Contributor License Agreement.

Codecov Report

Merging #141 into master will decrease coverage by 60.88%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #141       +/-   ##
==========================================
- Coverage   60.88%   0.00%   -60.89%     
==========================================
  Files          15       9        -6     
  Lines         519     165      -354     
  Branches      110      37       -73     
==========================================
- Hits          316       0      -316     
+ Misses        180     165       -15     
+ Partials       23       0       -23     

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33089da...8fec520. Read the comment docs.

@arnulfojr I don't get it. I can add multiple filters with version 5.4.5. Github says "This branch has no conflicts with the base branch", so I wonder, what did you exactly change?

E.g.

./bin/run read -t payments --filter=charged=false --filter=firefundpercentage=100 -x

rows where charged = false and firefundpercentage = 100

I pass the flags unaltered to cli.table()...

cli.table(dataList, convertToTableColumns(dataList), flags)

I don't get it. I can add multiple filters with version 5.4.5.

You can pass that. But they are not processed.

@MunifTanjim in my case they are processed and the table only renders the data that match my filters.

If I get time I can create a reduced test case but I suspect that you have experienced an edge case, that I am not seeing.

If I get time I can create a reduced test case but I suspect that you have experienced an edge case, that I am not seeing.

Data

x=1   y=a1
x=1   y=a2
x=1   y=b1
x=2   y=b2
x=2   y=c1

--filter=x=1 --filter=y=b

Expected Output

x=1   y=b1

Actual Output

Depending on the order of the passed filters,

x=1   y=a1
x=1   y=a2
x=1   y=b1

or

x=1   y=b1
x=2   y=b2

Cool! Can you add a multiple filter test? If you'd rather pass to #156 that's fine too.